feat(codepipeline): move all of the Pipeline Actions to their dedicated package #2098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladb
suggested changes
Mar 27, 2019
packages/@aws-cdk/app-delivery/lib/pipeline-deploy-stack-action.ts
Outdated
Show resolved
Hide resolved
skinny85
force-pushed
the
feature/consolidate-pipeline-actions
branch
from
f6d0b39
to
1455882
Compare
Done.
Done. |
RomainMuller
approved these changes
Mar 28, 2019
eladb
approved these changes
Mar 28, 2019
skinny85
force-pushed
the
adamruka/pipeline-actions-bind-api-refactor
branch
from
7416e9f
to
5f138fd
Compare
skinny85
force-pushed
the
feature/consolidate-pipeline-actions
branch
from
5d532ee
to
d405e53
Compare
|
Rebased on top of the newest changes. |
skinny85
changed the base branch from
adamruka/pipeline-actions-bind-api-refactor
to
master
…ed package. BREAKING CHANGE: this changes the package of all CodePipeline Actions to be aws-codepipeline-actions. BREAKING CHANGE: this moves all classes from the aws-codepipeline-api package to the aws-codepipeline package. BREAKING CHANGE: this changes the CodePipeline Action naming scheme from <service>.Pipeline<Category>Action (s3.PipelineSourceAction) to codepipeline_actions.<Service><Category>Action (cpactions.S3SourceAction).
skinny85
force-pushed
the
feature/consolidate-pipeline-actions
branch
from
4db5882
to
d074c5a
Compare
|
One more rebase after merging #2085 (GitHub got confused). |
This was referenced Mar 29, 2019
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: this changes the package of all CodePipeline Actions
to be aws-codepipeline-actions.
BREAKING CHANGE: this moves all classes from the aws-codepipeline-api package
to the aws-codepipeline package.
BREAKING CHANGE: this changes the CodePipeline Action naming scheme from
<service>.Pipeline<Category>Action(s3.PipelineSourceAction)to
codepipeline_actions.<Service><Category>Action(codepipeline_actions.S3SourceAction).This is to make it consistent with what we decided in #1743. It's also needed to break the cyclical dependency between the
assets,aws-codepipelineands3packages that is needed to complete #2057.I based it on the refactoring done in #2085, so as to minimize merge conflicts.
Pull Request Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.