-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(bootstrap): ECR ScanOnPush is now enabled by default
#17994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ScanOnPush is now enabled by default
rix0rrr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you just thumbs-up your own PR 🤓
|
@rix0rrr figured triaging sorts by reactions 😛 |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
@jerry-aws unsure about maintaining bootstrap template history in the CDK guide, but heads up just in case |
|
thanks @PatMyron. I'm not currently tracking that in the Dev Guide, but maybe it'd be a good idea to add a link directly to the template's GitHub history from there. What do you think? |
|
@jerry-aws agreed on linking the template source itself since the template history tables at the bottom get outdated otherwise: |
[`AWS::ECR::Repository.ImageScanningConfiguration`](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-ecr-repository.html#cfn-ecr-repository-imagescanningconfiguration) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
AWS::ECR::Repository.ImageScanningConfigurationBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license