feat(bootstrap): option to scan container asset images #16478
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
markusl
reviewed
Sep 16, 2021
| .option('bootstrap-customer-key', { type: 'boolean', desc: 'Create a Customer Master Key (CMK) for the bootstrap bucket (you will be charged but can customize permissions, modern bootstrapping only)', default: undefined, conflicts: 'bootstrap-kms-key-id' }) | ||
| .option('qualifier', { type: 'string', desc: 'Unique string to distinguish multiple bootstrap stacks', default: undefined }) | ||
| .option('public-access-block-configuration', { type: 'boolean', desc: 'Block public access configuration on CDK toolkit bucket (enabled by default) ', default: undefined }) | ||
| .option('container-asset-scan-on-push', { type: 'boolean', desc: 'Scan container asset images on push on CDK toolkit ECR (disabled by default)', default: false }) |
Contributor
There was a problem hiding this comment.
Why is this disabled by default?
Contributor
Author
There was a problem hiding this comment.
To match current behavior.
RomainMuller
force-pushed
the
master
branch
from
924c117 to
ebfd5f2
Compare
Contributor
Author
|
@markusl any changes I can make to get this PR mergeable? |
markusl
approved these changes
Oct 4, 2021
Contributor
|
@amirfireeye I cannot approve the changes to be merged here. You can ask someone from the CDK team for that |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
peterwoodworth
changed the title
Contributor
|
Superseded by #17994 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new flag for
cdk bootstrapcalled--container-asset-scan-on-push. It sets the generated ECR repo to be scanned on push for vulnerabilities.We need to enable scanning but would rather not modify the bootstrap template if possible. So this flag will help us automate the process more easily by just allowing a single step for bootstrapping instead of generating template, modifying, and then deploying.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license