-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ecs): add support for EC2 Capacity Providers #14386
Merged
+1,325
−70
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
01840f4
feat(ecs): add support for EC2 Capacity Providers
otterley a31c441
Apply suggestions from code review
otterley e7fc0bf
Update per reviewer feedback
otterley 1b9a860
Update packages/@aws-cdk/aws-ecs/README.md
otterley a75f3c6
Update packages/@aws-cdk/aws-ecs/README.md
otterley 287a6d9
Update packages/@aws-cdk/aws-ecs/README.md
otterley ccb9dc1
Update packages/@aws-cdk/aws-ecs/README.md
otterley 3627bd9
Update packages/@aws-cdk/aws-ecs/test/cluster.test.ts
otterley ecc9966
Updated to reflect review feedback
otterley 41899a9
Merge branch 'master' into ecs-ec2-capacity-provider
SoManyHs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can keep this section to include the bit on scaling on a metric -- this still applies in the context of ASG capacity providers.