feat(ecs): add support for EC2 Capacity Providers #14386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
the
@aws-cdk/aws-ec2
SoManyHs
reviewed
Apr 30, 2021
| autoScalingGroupProvider: { | ||
| autoScalingGroupArn: this.autoScalingGroup.autoScalingGroupName, | ||
| managedScaling: { | ||
| status: (props.enableManagedScaling === undefined || props.enableManagedScaling) ? 'ENABLED' : 'DISABLED', |
There was a problem hiding this comment.
What happens if enabledManagedScaling is not enabled but the other managedScaling fields are specified in the props? Could we add a test for that?
There was a problem hiding this comment.
I've reworked this code, LMK what you think.
SoManyHs
added
the
response-requested
|
|
github-actions
bot
removed
the
response-requested
SoManyHs
added
the
response-requested
2 tasks
otterley
force-pushed
the
ecs-ec2-capacity-provider
branch
3 times, most recently
from
1917213 to
7f6597b
Compare
github-actions
bot
removed
the
response-requested
|
@SoManyHs Ready for second review, thanks! |
SoManyHs
reviewed
May 11, 2021
There was a problem hiding this comment.
Looks great! The high number of comments are mostly renaming EC2 -> Asg as previously discussed -- also a few clarifications on tests.
| @@ -496,38 +493,6 @@ scaling.scaleOnRequestCount('RequestScaling', { | |||
| Task auto-scaling is powered by *Application Auto-Scaling*. | |||
| See that section for details. | |||
|
|
|||
| ## Instance Auto-Scaling | |||
There was a problem hiding this comment.
I think we can keep this section to include the bit on scaling on a metric -- this still applies in the context of ASG capacity providers.
SoManyHs
reviewed
May 11, 2021
Co-authored-by: Hsing-Hui Hsu <[email protected]>
Co-authored-by: Hsing-Hui Hsu <[email protected]>
Co-authored-by: Hsing-Hui Hsu <[email protected]>
Co-authored-by: Hsing-Hui Hsu <[email protected]>
Co-authored-by: Hsing-Hui Hsu <[email protected]>
Co-authored-by: Hsing-Hui Hsu <[email protected]>
otterley
force-pushed
the
ecs-ec2-capacity-provider
branch
4 times, most recently
from
5876422 to
cfb0453
Compare
otterley
force-pushed
the
ecs-ec2-capacity-provider
branch
5 times, most recently
from
b3fcb11 to
b06f7db
Compare
|
@SoManyHs Ready for the next review pass! |
SoManyHs
reviewed
May 12, 2021
otterley
force-pushed
the
ecs-ec2-capacity-provider
branch
from
b06f7db to
ecc9966
Compare
SoManyHs
previously approved these changes
May 12, 2021
SoManyHs
approved these changes
May 12, 2021
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This was referenced May 13, 2021
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
Add support for EC2 Capacity Providers. I tried to make the UX reasonably decent without disrupting existing stacks. There are some new types being created here, including `ICapacityProvider` (interface type) and its concrete type `EC2CapacityProvider` (which is a class users can instantiate). There are also a couple of singleton classes for `FargateCapacityProvider` and `FargateSpotCapacityProvider`. Closes aws#5471 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
njlynch
added a commit
that referenced
this pull request
Nov 23, 2021
The `Cluster.addCapacity` method was deprecated in #14386 as part of the introduction of `Cluster.addAsgCapacityProvider`. However, the corresponding `ClusterProps.capacity` property and `AddCapacityOptions` interface were not deprecated, leading to a confusing mismash of deprecated and undeprecated usage. The README for ECS still heavily references `Cluster.addCapacity`, further leading to potential confusion for users just following the module's guidance. As part of cleaning up deprecated usage as part of the lead-up to the V2 launch, opting to un-deprecate the `addCapacity` method rather than deprecating the other two elements and rewriting the README.
mergify bot
pushed a commit
that referenced
this pull request
Nov 23, 2021
The `Cluster.addCapacity` method was deprecated in #14386 as part of the introduction of `Cluster.addAsgCapacityProvider`. However, the corresponding `ClusterProps.capacity` property and `AddCapacityOptions` interface were not deprecated, leading to a confusing mismash of deprecated and undeprecated usage. The README for ECS still heavily references `Cluster.addCapacity`, further leading to potential confusion for users just following the module's guidance. As part of cleaning up deprecated usage as part of the lead-up to the V2 launch, opting to un-deprecate the `addCapacity` method rather than deprecating the other two elements and rewriting the README. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mergify bot
pushed a commit
that referenced
this pull request
Nov 23, 2021
The `Cluster.addCapacity` method was deprecated in #14386 as part of the introduction of `Cluster.addAsgCapacityProvider`. However, the corresponding `ClusterProps.capacity` property and `AddCapacityOptions` interface were not deprecated, leading to a confusing mismash of deprecated and undeprecated usage. The README for ECS still heavily references `Cluster.addCapacity`, further leading to potential confusion for users just following the module's guidance. As part of cleaning up deprecated usage as part of the lead-up to the V2 launch, opting to un-deprecate the `addCapacity` method rather than deprecating the other two elements and rewriting the README. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* (cherry picked from commit 765c274)
beezly
pushed a commit
to beezly/aws-cdk
that referenced
this pull request
Nov 29, 2021
The `Cluster.addCapacity` method was deprecated in aws#14386 as part of the introduction of `Cluster.addAsgCapacityProvider`. However, the corresponding `ClusterProps.capacity` property and `AddCapacityOptions` interface were not deprecated, leading to a confusing mismash of deprecated and undeprecated usage. The README for ECS still heavily references `Cluster.addCapacity`, further leading to potential confusion for users just following the module's guidance. As part of cleaning up deprecated usage as part of the lead-up to the V2 launch, opting to un-deprecate the `addCapacity` method rather than deprecating the other two elements and rewriting the README. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
The `Cluster.addCapacity` method was deprecated in aws#14386 as part of the introduction of `Cluster.addAsgCapacityProvider`. However, the corresponding `ClusterProps.capacity` property and `AddCapacityOptions` interface were not deprecated, leading to a confusing mismash of deprecated and undeprecated usage. The README for ECS still heavily references `Cluster.addCapacity`, further leading to potential confusion for users just following the module's guidance. As part of cleaning up deprecated usage as part of the lead-up to the V2 launch, opting to un-deprecate the `addCapacity` method rather than deprecating the other two elements and rewriting the README. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for EC2 Capacity Providers.
I tried to make the UX reasonably decent without disrupting existing stacks. There are some new types being created here, including
ICapacityProvider(interface type) and its concrete typeEC2CapacityProvider(which is a class users can instantiate). There are also a couple of singleton classes forFargateCapacityProviderandFargateSpotCapacityProvider.Closes #5471
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license