chore(ubergen): copy .npmignore into monopackage
#13642
Conversation
`.npmignore` did not use to be copied into the directories of the monopackage, leading to files that *ought* to have been excluded to not be excluded. Remove the file from the list of files that doesn't get copied to fix this. This fix is not along the lines of the method suggested in the linked issue, but it does address the original problem. Fixes #12292.
|
|
| '.gitignore', | ||
| '.jest.config.js', | ||
| '.jsii', | ||
| '.npmignore', |
There was a problem hiding this comment.
Interesting! I didn't know that .npmignore can be placed in subdirectories of a package and be respected by "npm pack"...
There was a problem hiding this comment.
It does indeed.
https://docs.npmjs.com/cli/v7/using-npm/developers#keeping-files-out-of-your-package
Like
git,npmlooks for.npmignoreand.gitignorefiles in all subdirectories of your package, not only the root directory.
nija-at
left a comment
nija-at
left a comment
There was a problem hiding this comment.
Simple and effective. Love it!
| '.gitignore', | ||
| '.jest.config.js', | ||
| '.jsii', | ||
| '.npmignore', |
There was a problem hiding this comment.
It does indeed.
https://docs.npmjs.com/cli/v7/using-npm/developers#keeping-files-out-of-your-package
Like
git,npmlooks for.npmignoreand.gitignorefiles in all subdirectories of your package, not only the root directory.
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
`.npmignore` did not use to be copied into the directories of the monopackage, leading to files that *ought* to have been excluded to not be excluded. Remove the file from the list of files that doesn't get copied to fix this. This fix is not along the lines of the method suggested in the linked issue, but it does address the original problem. Fixes #12292. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
`.npmignore` did not use to be copied into the directories of the monopackage, leading to files that *ought* to have been excluded to not be excluded. Remove the file from the list of files that doesn't get copied to fix this. This fix is not along the lines of the method suggested in the linked issue, but it does address the original problem. Fixes aws#12292. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
4 participants
.npmignoredid not use to be copied into the directories of the monopackage,leading to files that ought to have been excluded to not be excluded.
Remove the file from the list of files that doesn't get copied to fix this.
This fix is not along the lines of the method suggested in the linked issue,
but it does address the original problem.
Fixes #12292.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license