-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Closed
Closed
Copy link
Labels
aws-cdk-libRelated to the aws-cdk-lib packageRelated to the aws-cdk-lib packagebugThis issue is a bug.This issue is a bug.effort/mediumMedium work item – several days of effortMedium work item – several days of effortmonocdkRelated to the monocdk packageRelated to the monocdk packagep1
Description
The .npmignore files in monocdk submodules are not respected since there could be only one npmignore in an npm package (the root one). This means that the monocdk module includes files that are not supposed to be there.
Reproduction Steps
For example, monocdk/lib/lambda-layer-awscli submodule includes a layer directory which is .npmignored in the normal module.
What did you expect to happen?
ubergen needs to process the .npmignore files in submodules and either exclude those files from the staging of monocdk or "hoist" them into the top-level npmignore files of monocdk (with the proper subdirectory prefix).
What actually happened?
The monocdk library bundles files that are not supposed to be included.
Environment
- CDK CLI Version : 1.81.0
- Framework Version: 1.81.0
- Node.js Version: N/A
- OS : N/A
- Language (Version): N/A
This is 🐛 Bug Report
Metadata
Metadata
Assignees
Labels
aws-cdk-libRelated to the aws-cdk-lib packageRelated to the aws-cdk-lib packagebugThis issue is a bug.This issue is a bug.effort/mediumMedium work item – several days of effortMedium work item – several days of effortmonocdkRelated to the monocdk packageRelated to the monocdk packagep1