Skip to content

Conversation

@trivikr
Copy link
Member

@trivikr trivikr commented Feb 23, 2021

Description

Follow-up to #12807

Reasons for recommending NODEJS_14_X:

  • Node.js 12.x went LTS in October 2019, and has been actively supported since October 2020.
  • Node.js 14.x went LTS in October 2020, and is now actively supported LTS version.

Lambda added support for Node.js 14.x runtime on 2021-02-03

Testing

Verified that all changes in README are either:

  • Direct calls to lambda.Function
  • Indirect calls, like through cloudfront.experimental.EdgeFunction

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Feb 23, 2021

@github-actions github-actions bot added the @aws-cdk/aws-lambda Related to AWS Lambda label Feb 23, 2021
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 6df71ea
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nija-at
Copy link
Contributor

nija-at commented Feb 25, 2021

As far as I know, CloudFormation does not yet support the ZipFile property for Node14. (needs to be confirmed)

If this is this case, Code.fromInline() API will not work for Node14. Should we be recommending Node14?

Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gliptak
Copy link

gliptak commented Jun 1, 2021

Just checked and nodejs14.x ZipFile still shows:

Resource handler returned message: "Invalid request provided: The ZipFile attribute is not supported for the runtime 'nodejs14.x'"

@gliptak
Copy link

gliptak commented Jun 1, 2021

@gliptak
Copy link

gliptak commented Jun 9, 2021

@nija-at
Copy link
Contributor

nija-at commented Jul 19, 2021

Closing this pull request. Please submit a new pull request when support for CloudFormation inline is available.

@nija-at nija-at closed this Jul 19, 2021
@trivikr trivikr deleted the recommend-nodejs-14-in-readme branch August 10, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

@aws-cdk/aws-lambda Related to AWS Lambda

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants