Skip to content

Conversation

@trivikr
Copy link
Member

@trivikr trivikr commented Feb 1, 2021

Follow-up to #12713
This PR recommends NODEJS_12_X instead of NODEJS_10_X in aws-cdk READMEs.

Reasons for recommending NODEJS_12_X:

  • Node.js 10.x is going end-of-life on April 30th, 2021
  • Node.js 12.x went LTS in October 2019, and has been actively supported till October 2020.
  • Node.js 14.x went LTS in October 2020, and is now actively supported LTS version.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Feb 1, 2021

@nija-at nija-at changed the title docs: recommend lambda.Runtime.NODEJS_12_X as 10.x is going EoL docs: recommend lambda runtime nodejs12.x Feb 23, 2021
@mergify
Copy link
Contributor

mergify bot commented Feb 23, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions github-actions bot added the @aws-cdk/aws-lambda Related to AWS Lambda label Feb 23, 2021
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: a6a69eb
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Feb 23, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit ed86c66 into aws:master Feb 23, 2021
@trivikr trivikr deleted the update-lambda-runtime-NODEJS-readme branch February 23, 2021 16:58
mergify bot pushed a commit that referenced this pull request Feb 23, 2021
…_X (#13227)

### Description
This PR documents only NODEJS_10_X for EvaluateExpression. It was mistakenly changed to NODEJS_12_X in bulk PR #12807

Issue which requests supports NODEJS_12_X version by default in EvaluateExpression #13224

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

@aws-cdk/aws-lambda Related to AWS Lambda

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants