Skip to content

refactor(cli): property bag for refreshStacks function #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 19, 2025
Merged

refactor(cli): property bag for refreshStacks function #855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5cf6765
refactor(gc): use property bag for refreshStacks function
gandhya Sep 18, 2025
1b3fe89
Merge branch 'main' into refresh-stacks-bag-update
kaizencc Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/@aws-cdk/toolkit-lib/lib/api/garbage-collection/garbage-collector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,12 @@ export class GarbageCollector {
const activeAssets = new ActiveAssetCache();

// Grab stack templates first
await refreshStacks(cfn, this.ioHelper, activeAssets, qualifier);
await refreshStacks({
cfn,
ioHelper: this.ioHelper,
activeAssets,
qualifier,
});
// Start the background refresh
const backgroundStackRefresh = new BackgroundStackRefresh({
cfn,
Expand Down
20 changes: 16 additions & 4 deletions packages/@aws-cdk/toolkit-lib/lib/api/garbage-collection/stack-refresh.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,11 +97,18 @@ function bootstrapFilter(parameters?: ParameterDeclaration[], qualifier?: string
splitBootstrapVersion[2] != qualifier);
}

export async function refreshStacks(cfn: ICloudFormationClient, ioHelper: IoHelper, activeAssets: ActiveAssetCache, qualifier?: string) {
export interface RefreshStacksProps {
readonly cfn: ICloudFormationClient;
readonly ioHelper: IoHelper;
readonly activeAssets: ActiveAssetCache;
readonly qualifier?: string;
}

export async function refreshStacks(props: RefreshStacksProps) {
try {
const stacks = await fetchAllStackTemplates(cfn, ioHelper, qualifier);
const stacks = await fetchAllStackTemplates(props.cfn, props.ioHelper, props.qualifier);
for (const stack of stacks) {
activeAssets.rememberStack(stack);
props.activeAssets.rememberStack(stack);
}
} catch (err) {
throw new ToolkitError(`Error refreshing stacks: ${err}`);
Expand Down Expand Up @@ -154,7 +161,12 @@ export class BackgroundStackRefresh {
private async refresh() {
const startTime = Date.now();

await refreshStacks(this.props.cfn, this.props.ioHelper, this.props.activeAssets, this.props.qualifier);
await refreshStacks({
cfn: this.props.cfn,
ioHelper: this.props.ioHelper,
activeAssets: this.props.activeAssets,
qualifier: this.props.qualifier,
});
this.justRefreshedStacks();

// If the last invocation of refreshStacks takes <5 minutes, the next invocation starts 5 minutes after the last one started.
Expand Down
Loading