refactor(cli): property bag for refreshStacks function #855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace 4 individual parameters with a single props object to make readability better
dgandhi62
had a problem deploying
to
integ-approval
GitHub Actions
Failure
dgandhi62
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #855 +/- ##
==========================================
- Coverage 83.79% 83.41% -0.38%
==========================================
Files 65 65
Lines 9558 9558
Branches 1137 1133 -4
==========================================
- Hits 8009 7973 -36
- Misses 1527 1561 +34
- Partials 22 24 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kaizencc
approved these changes
Sep 19, 2025
kaizencc
temporarily deployed
to
integ-approval
GitHub Actions
Inactive
iankhou
pushed a commit
that referenced
this pull request
Oct 7, 2025
The refreshStacks function currently takes 4 individual parameters, making it difficult to maintain as new parameters are added. This change: - Introduces a `RefreshStacksProps` interface to group function parameters - Refactors the `refreshStacks` function signature to accept a single props object --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license Co-authored-by: Dhyan Gandhi <[email protected]> Co-authored-by: Kaizen Conroy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refreshStacks function currently takes 4 individual parameters, making it difficult to maintain as new parameters are added.
This change:
RefreshStacksPropsinterface to group function parametersrefreshStacksfunction signature to accept a single props objectBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license