fix: minor Blue/Green fixes #1441
Conversation
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/[email protected]
with:
upload-result: trueContact Qodana teamContact us at [email protected]
|
wrapper/src/main/java/software/amazon/jdbc/plugin/bluegreen/BlueGreenConnectionPlugin.java
Outdated
Show resolved
Hide resolved
wrapper/src/main/java/software/amazon/jdbc/plugin/bluegreen/BlueGreenStatusProvider.java
Outdated
Show resolved
Hide resolved
wrapper/src/main/java/software/amazon/jdbc/plugin/bluegreen/BlueGreenStatusProvider.java
Outdated
Show resolved
Hide resolved
wrapper/src/main/java/software/amazon/jdbc/plugin/bluegreen/BlueGreenStatusProvider.java
Outdated
Show resolved
Hide resolved
| if (conn == null) { | ||
|
|
||
| this.bgStatus = this.pluginService.getStatus(BlueGreenStatus.class, this.bgdId); | ||
| if (this.bgStatus == null) { |
There was a problem hiding this comment.
this.endTimeNano won't be set up in such case.
There was a problem hiding this comment.
I think it will, when the return statement is hit we will automatically enter the finally block which sets the endTimeNano if it hasn't been set yet. But let me know if I'm incorrect
There was a problem hiding this comment.
Then the measured time includes an actual connect time. Original idea was to measure that routing time. If it's easy to fix I'd prefer just routing time.
There was a problem hiding this comment.
I see, okay I've updated the code to set the end time before connecting
2 participants
Minor Blue/Green fixes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.