Skip to content

Conversation

@karenc-bq
Copy link
Contributor

Summary

The AWS Java SDK may return WRITER:
https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/services/rds/model/CreateDbClusterEndpointResponse.html#customEndpointType()

Description

Additional Reviewers

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions
Copy link

github-actions bot commented Nov 26, 2024

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Contact Qodana team

Contact us at [email protected]

Copy link
Contributor

@aaron-congo aaron-congo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SDK page you linked does seem to indicate that the WRITER type is possible, but this page seems to contradict that:
"Each custom endpoint has an associated type that determines which DB instances are eligible to be associated with that endpoint. Currently, the type can be READER or ANY."

Do we want to add this anyways?

@karenc-bq
Copy link
Contributor Author

The SDK page you linked does seem to indicate that the WRITER type is possible, but this page seems to contradict that: "Each custom endpoint has an associated type that determines which DB instances are eligible to be associated with that endpoint. Currently, the type can be READER or ANY."

Do we want to add this anyways?

I am leaning towards us matching with whatever the API returns so we are not caught off guard when WRITER type endpoints are supported.

@karenc-bq karenc-bq force-pushed the fix/custom-endpoint-type branch from 72e5025 to 4388691 Compare November 28, 2024 19:44
@karenc-bq karenc-bq enabled auto-merge (squash) November 28, 2024 19:55
@karenc-bq karenc-bq merged commit b8e749d into main Nov 28, 2024
6 checks passed
@karenc-bq karenc-bq deleted the fix/custom-endpoint-type branch June 13, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants