fix: unwrap nested exceptions when checking for login exceptions #1111
Conversation
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/[email protected]
with:
upload-result: trueContact Qodana teamContact us at [email protected]
|
| } | ||
|
|
||
| if (isLoginException(sqlState)) { | ||
| return true; |
There was a problem hiding this comment.
Super tiny nitpick:
I think the above could be simplified like this. Not sure if its less readable now though due to the longer condition.
if (exception instanceof SQLException
&& isLoginException(((SQLException) exception).getSQLState())) {
return true;
}
What do you think?
There was a problem hiding this comment.
Yeah I wasn't sure which of these two was preferable, I'm fine with either one
There was a problem hiding this comment.
Yeah, same here. Im fine with either one.
I'll slap an approval on it :P
aaron-congo
force-pushed
the
issue-1081
branch
from
0d05689 to
2a85895
Compare
3 participants
Summary
fix: unwrap nested exceptions when checking for login exceptions
Description
Additional Reviewers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.