-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configurable default profile #3365
Conversation
92f2f2f
to
16c3cfe
Compare
agent/credentials/providers/rotating_shared_credentials_provider.go
Outdated
Show resolved
Hide resolved
16c3cfe
to
b06f2fa
Compare
b06f2fa
to
d5cf570
Compare
d5cf570
to
cd80eec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: sorry for my poor English but can you help me understand why you choose alternate
over alternative
? Thanks!
Edit: nvm I kinda understand it - the idea you want to convey here is it is not another optional but an override. Not sure if there are better word options to avoid the confusion that this is going to be used as a backup profile - considering it is not a back up but an override.
They're essentially synonyms. 'alternate is frequently used to mean "offering or expressing a choice." There are established uses for both that we regularly encounter: a director's cut of a film may feature an alternate ending; a traffic update warns motorists to seek an alternate route. https://www.merriam-webster.com/words-at-play/differences-between-alternate-and-alternative |
Summary
Update to allow for a configurable alternate credential profile other than
default
.#3241
Implementation details
Add a new env var,
ECS_ALTERNATE_CREDENTIAL_PROFILE
, to allow for overriding the default credential profile.Testing
built agent with existing logging in place. updated /etc/ecs/ecs.config to add
checked info level logs for the override message.
New tests cover the changes: yes
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.