Remove hardcoded default credential profile #3338
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fault profile if none is specified. This allows the end user to override the profile in /etc/ecs/ecs.config with the environment variable AWS_PROFILE Update TestNewRotatingSharedCredentialsProvider to match implementation
sunds
force-pushed
the
remove-hardcoded-default-credential-profile
branch
from
4991dff to
54c4eef
Compare
|
closing in favor of #3365 which was merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove hard-coded "default" profile for credentials. The AWS SDK will already fall back to default if no profile is selected. This allows the customer to specify alternate profiles in their environment.
Implementation details
Remove the hard-coded value and update the unit tests
Testing
Unit tests were successfully run on Ubuntu 20.04 with Golang 1.18
New tests cover the changes: Yes. No new lines were added to the codebase.
Description for the changelog
Enhancement - Remove hard-coded "default" profile for credentials to allow their specification from the environment with fallback to "default".
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.