fix(mypy): addresses lack of optional types

[michaelbrewer]

Issue #, if available:

Description of changes:

Resolve mypy errors, down from 124 to 30 :-) .

Changes:

• Resolve errors related to the "no_implicit_optional" flag in mypy.ini
• Fix typing for resolve_truthy_env_var_choice

Checklist

• Meet tenets criteria
• Update tests
• Update docs
• PR title follows conventional commit semantics

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[michaelbrewer]

@heitorlessa with no_implicit_optional=True we have alot more errors coming through in PyCharm.

[codecov-commenter]

Codecov Report

Merging #521 (02fc79b) into develop (c0c32bc) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #521   +/-   ##
========================================
  Coverage    99.23%   99.23%           
========================================
  Files          113      113           
  Lines         4468     4468           
  Branches       243      243           
========================================
  Hits          4434     4434           
  Misses          22       22           
  Partials        12       12           

Impacted Files	Coverage Δ
aws_lambda_powertools/logging/formatter.py	100.00% <ø> (ø)
aws_lambda_powertools/logging/logger.py	100.00% <ø> (ø)
...da_powertools/utilities/idempotency/idempotency.py	98.57% <ø> (ø)
...wertools/utilities/idempotency/persistence/base.py	99.36% <ø> (ø)
...ambda_powertools/utilities/validation/validator.py	100.00% <ø> (ø)
aws_lambda_powertools/event_handler/api_gateway.py	100.00% <100.00%> (ø)
aws_lambda_powertools/event_handler/appsync.py	100.00% <100.00%> (ø)
aws_lambda_powertools/metrics/base.py	100.00% <100.00%> (ø)
aws_lambda_powertools/metrics/metric.py	100.00% <100.00%> (ø)
aws_lambda_powertools/metrics/metrics.py	100.00% <100.00%> (ø)
... and 7 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0c32bc...02fc79b. Read the comment docs.

[heitorlessa]

only one question on whether Optional[Sequence] is the correct type for __build_config as opposed to Union[List, Tuple, None]

[heitorlessa]

I've just tried fixing the Union[Tuple, List] with a Sequence and it worked w/ MyPy -- perhaps I have MyPy misconfigured in PyCharm?

I'll look into other bug now then merge as-is if you're still seeing the issue.

from typing import Any, Callable, Dict, List, Optional, Tuple, Union, Sequence

    def __init__(
        self,
        service: Optional[str] = None,
        disabled: Optional[bool] = None,
        auto_patch: Optional[bool] = None,
        patch_modules: Optional[Sequence[str]] = None,
        provider: Optional[BaseProvider] = None,
    ):

    def patch(self, modules: Optional[Sequence[str]] = None):
      
    def __build_config(
        self,
        service: Optional[str] = None,
        disabled: Optional[bool] = None,
        auto_patch: Optional[bool] = None,
        patch_modules: Optional[Sequence[str]] = None,
        provider: Optional[BaseProvider] = None,
    ):

I've also added the following modules to ignore their lack of typehints, which makes me wonder how reliable this is: https://pypi.org/project/mypy-boto3/

[mypy-boto3]
ignore_missing_imports = True

[mypy-boto3.dynamodb.conditions]
ignore_missing_imports = True

[mypy-botocore.config]
ignore_missing_imports = True

[mypy-botocore.exceptions]
ignore_missing_imports = True

[mypy-aws_xray_sdk.ext.aiohttp.client]
ignore_missing_imports = True

[michaelbrewer]

@heitorlessa ok your suggestions work prefectly, i have pushed the latest