-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api-gateway): add debug mode #507
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #507 +/- ##
========================================
Coverage 99.90% 99.90%
========================================
Files 107 107
Lines 4266 4280 +14
Branches 208 212 +4
========================================
+ Hits 4262 4276 +14
Misses 1 1
Partials 3 3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! One minor change in env var. QQ: how helpful would it be to literally print
the event when this flag is enabled too?
I think this could be handled by Logger with the LOG_EVENT piece, so I'm on the fence.
Maybe as a debug tip to turn on log event environment variable. |
@heitorlessa ok it is all merged up. |
@heitorlessa i added the print of the request |
I added the print part |
@heitorlessa any other updates needed? |
Thanks a lot for the changes - I’ll check as soon as I can on Friday or
early next week
…On Wed, 7 Jul 2021 at 20:04, Michael Brewer ***@***.***> wrote:
@heitorlessa <https://github.com/heitorlessa> any other updates needed?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#507 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZPQBHMBK4TMUWLU7KNR33TWSJMLANCNFSM47ZNVXDA>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's great, one tiny change so we don't use mock in a functional test and capture stdout instead, then it's good to merge :)
You know, it'd be great to have permissions to push these so I don't have to bother ya ;)
Co-authored-by: Heitor Lessa <[email protected]>
i think that only works if i do it via my personal account :) |
* develop: chore(deps): bump boto3 from 1.18.0 to 1.18.1 (aws-powertools#528) fix(tracer): mypy generic to preserve decorated method signature (aws-powertools#529) fix(parser): Make ApiGateway version, authorizer fields optional (aws-powertools#532) fix(mypy): fixes to resolve no implicit optional errors (aws-powertools#521) chore(deps): bump boto3 from 1.17.110 to 1.18.0 (aws-powertools#527) feat(feat-toggle): New simple feature toggles rule engine (WIP) (aws-powertools#494) chore(deps-dev): bump mkdocs-material from 7.1.9 to 7.1.10 (aws-powertools#522) chore(deps): bump boto3 from 1.17.102 to 1.17.110 (aws-powertools#523) chore(deps-dev): bump isort from 5.9.1 to 5.9.2 (aws-powertools#514) feat(mypy): add mypy support to makefile (aws-powertools#508) feat(api-gateway): add debug mode (aws-powertools#507)
Issue #, if available:
Pairs with #506
Description of changes:
Add debug mode support:
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.