Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React documentation prefers Authenticator over withAuthenticator #783

Merged
merged 4 commits into from
Nov 19, 2021

Conversation

ericclemmons
Copy link
Contributor

Issue #, if available: Closes #640

Using the past is more component composition friendly compared to the new HOC withAuthenticator. I guess the new UI is not backward compatible as I have tried to simply replace with the new , but it doesn't work.

This will also make way for use cases like https://codesandbox.io/s/change-your-layout-rh4z9?file=/src/App.js with useAuthenticator.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ericclemmons ericclemmons requested a review from ErikCH November 18, 2021 19:21
@ericclemmons ericclemmons self-assigned this Nov 18, 2021
@changeset-bot
Copy link

changeset-bot bot commented Nov 18, 2021

⚠️ No Changeset found

Latest commit: a18130f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ericclemmons ericclemmons added Documentation An issue or a feature-request for our Amplify UI Doc site or AWS Amplify docs React An issue or a feature-request for React platform labels Nov 18, 2021
@lgtm-com
Copy link

lgtm-com bot commented Nov 18, 2021

This pull request fixes 1 alert when merging 218d103 into 2557192 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

Copy link
Contributor

@reesscot reesscot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lgtm-com
Copy link

lgtm-com bot commented Nov 19, 2021

This pull request fixes 1 alert when merging a18130f into 1bfdd0f - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@ericclemmons ericclemmons temporarily deployed to ci November 19, 2021 15:29 Inactive
@ericclemmons ericclemmons temporarily deployed to ci November 19, 2021 15:29 Inactive
@ericclemmons ericclemmons temporarily deployed to ci November 19, 2021 15:29 Inactive
@ericclemmons ericclemmons temporarily deployed to ci November 19, 2021 15:47 Inactive
@ericclemmons ericclemmons enabled auto-merge (squash) November 19, 2021 15:48
@ericclemmons ericclemmons merged commit a3a9e9c into main Nov 19, 2021
@ericclemmons ericclemmons deleted the 640-authenticator branch November 19, 2021 15:52
thaddmt pushed a commit that referenced this pull request Apr 7, 2023
…migration-prep

chore(react-liveness): prepare for service code migration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation An issue or a feature-request for our Amplify UI Doc site or AWS Amplify docs React An issue or a feature-request for React platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Examples on new <Authenticator/> instead of the HOC withAuthenticator, migration docs.
2 participants