Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removing resolution since upstream has fixed the issue #1422

Merged
merged 4 commits into from
Feb 26, 2022

Conversation

zchenwei
Copy link
Contributor

@zchenwei zchenwei commented Feb 25, 2022

Description of changes

Removing resolution for eslint-plugin-react since it got fixed upstream now

Issue #, if available

jsx-eslint/eslint-plugin-react#3215

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@changeset-bot
Copy link

changeset-bot bot commented Feb 25, 2022

⚠️ No Changeset found

Latest commit: a7ac155

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@joebuono joebuono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -59,7 +59,6 @@
"node-forge": "1.0.0",
"prismjs": "^1.25.0",
"prism-react-renderer": "1.2.1",
"eslint-plugin-react": "7.28.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one more in

"resolutions": {
"eslint-plugin-react": "7.28.0"
},
, can you remove that as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, just realized canary package is not part of the mono repo in terms of workspaces

@zchenwei zchenwei enabled auto-merge (squash) February 26, 2022 01:44
@zchenwei zchenwei temporarily deployed to ci February 26, 2022 01:53 Inactive
@zchenwei zchenwei temporarily deployed to ci February 26, 2022 01:53 Inactive
@zchenwei zchenwei temporarily deployed to ci February 26, 2022 01:53 Inactive
@zchenwei zchenwei temporarily deployed to ci February 26, 2022 01:53 Inactive
@zchenwei zchenwei merged commit a4499fc into main Feb 26, 2022
@zchenwei zchenwei deleted the chenwz-remove-resolution branch February 26, 2022 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants