-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: removing resolution since upstream has fixed the issue #1422
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -59,7 +59,6 @@ | |||
"node-forge": "1.0.0", | |||
"prismjs": "^1.25.0", | |||
"prism-react-renderer": "1.2.1", | |||
"eslint-plugin-react": "7.28.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's one more in
amplify-ui/canary/react/next/package.json
Lines 17 to 19 in 625efeb
"resolutions": { | |
"eslint-plugin-react": "7.28.0" | |
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, just realized canary package is not part of the mono repo in terms of workspaces
Description of changes
Removing resolution for
eslint-plugin-react
since it got fixed upstream nowIssue #, if available
jsx-eslint/eslint-plugin-react#3215
Description of how you validated changes
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.