-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Update api pubsub peer dependencies to 3.0.22 #6499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update api pubsub peer dependencies to 3.0.22 #6499
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6499 +/- ##
=======================================
Coverage 73.26% 73.26%
=======================================
Files 208 208
Lines 12920 12920
Branches 2525 2525
=======================================
Hits 9466 9466
Misses 3263 3263
Partials 191 191 Continue to review full report at Codecov.
|
|
It looks like the dependency on |
ericclemmons
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR! Yes, your sleuthing was correct: that previous change was to fix lerna's topological sort behavior :)
I think we can safely get this shipped with just changes to peerDependencies 🙏
Move pubsub devDep to dependencies in api-graphql
ericclemmons
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I updated this to include work from #6282 and will merge once tests pass 🙏
Co-authored-by: Eric Clemmons <[email protected]>
Co-authored-by: Eric Clemmons <[email protected]>
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Issue #, if available: #6061
Description of changes:
apiandapi-graphqlto 3.0.22It seems that the dependencies listed on
apiandapi-graphqlare incorrect. I believe this is an error since in the git blame, thedependencieswas updated automatically very recently while thepeerDependenciesseems untouched since 8 months ago.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.