Skip to content

Conversation

@joeltio
Copy link
Contributor

@joeltio joeltio commented Aug 5, 2020

Issue #, if available: #6061

Description of changes:

  • Update peer dependencies of api and api-graphql to 3.0.22
  • Remove unnecessary pubsub dependency when already listed in peer dependencies.

It seems that the dependencies listed on api and api-graphql are incorrect. I believe this is an error since in the git blame, the dependencies was updated automatically very recently while the peerDependencies seems untouched since 8 months ago.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #6499 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6499   +/-   ##
=======================================
  Coverage   73.26%   73.26%           
=======================================
  Files         208      208           
  Lines       12920    12920           
  Branches     2525     2525           
=======================================
  Hits         9466     9466           
  Misses       3263     3263           
  Partials      191      191           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e311464...e179eeb. Read the comment docs.

@joeltio
Copy link
Contributor Author

joeltio commented Aug 6, 2020

It looks like the dependency on pubsub in api-graphql was added in #5352 to prevent race conditions. I have added them back but now in devDependencies. Checking the lerna topological sort, it has the same effect and I think it makes more sense since its sole purpose of being there is for lerna to build the packages in the right order and not for users to install.

Copy link
Contributor

@ericclemmons ericclemmons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! Yes, your sleuthing was correct: that previous change was to fix lerna's topological sort behavior :)

I think we can safely get this shipped with just changes to peerDependencies 🙏

@joeltio joeltio requested a review from ericclemmons August 12, 2020 12:22
Copy link
Contributor

@ericclemmons ericclemmons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I updated this to include work from #6282 and will merge once tests pass 🙏

@ericclemmons ericclemmons merged commit d50933b into aws-amplify:main Aug 13, 2020
nubpro pushed a commit to nubpro/amplify-js that referenced this pull request Oct 2, 2020
iartemiev pushed a commit that referenced this pull request Oct 13, 2020
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants