fix(@aws-amplify/api-graphql): Add missing @aws-amplify/pubsub dependency #5352
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
yarn buildlocally, I identified a race-condition where@aws-amplify/api-graphql's build was failing due to@aws-amplify/pubsubnot being built yet.This has come up in the past, and the solution is simple: explicitly add dependencies to
package.json:amplify-js/packages/api-graphql/src/GraphQLAPI.ts
Line 25 in 27355a4
Missing
@aws-amplify/pubsub:amplify-js/packages/api-graphql/package.json
Lines 38 to 46 in 27355a4
With this change,
lerna's topological sort correctly build@aws-amplify/pubsubbefore@aws-amplify/api-graphql.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.