fix(auth): handle custom Cognito domains without appending regional suffix #3024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uffix Ensure fullDomainPath uses the custom domain as-is when provided, falling back to the Cognito-managed domain construction only if no custom domain exists. This resolves malformed OAuth redirect URLs when using imported Cognito resources with SSO.
…th scenarios - Add test for custom domain with external login providers - Add test for cognito-managed domain with external login providers - Verify oauthCognitoDomain is correctly set for both scenarios
🦋 Changeset detectedLatest commit: 588096b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
.changeset/honest-chairs-rescue.md
Outdated
There was a problem hiding this comment.
since you have another change set file, you should be able to remove this one
ShadowCat567
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using imported Cognito resources in Amplify Gen2 with SSO enabled, login redirects were broken because the initializer Lambda unconditionally appended
.auth.{region}.amazoncognito.comto the OAuth domain.This caused malformed redirect URLs when a custom domain was already set in the Cognito User Pool (e.g.,
auth.dev.example.com→auth.dev.example.com.auth.us-east-1.amazoncognito.com).Issue number, if available: #2991
Changes
This fixes the malformed OAuth redirect URLs when signing in via SSO providers (e.g., Google).
Validation
Checklist
run-e2elabel set.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.