Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Sep 25, 2025

Problem

The current CI workflow has separate ulimit increase steps, but ulimit changes don't persist across GitHub Actions steps. Each step runs in its own shell session, so the ulimit increase has no effect on subsequent test execution steps.

Changes

  • Remove ineffective dedicated "Increase ulimit" steps from GitHub Actions workflows
  • Move ulimit increase inline with test execution commands so it applies to the same shell session
  • Apply ulimit only when running on macOS runners where it's needed

Validation

This change fixes the ulimit configuration that was previously ineffective. The ulimit increase now actually applies to the test execution since it runs in the same shell session.

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mrgrain mrgrain requested a review from a team as a code owner September 25, 2025 17:18
@changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2025

⚠️ No Changeset found

Latest commit: 0db8fe2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mrgrain mrgrain force-pushed the mrgrain/chore/per-step-ulimit branch from de89fa4 to 0db8fe2 Compare September 25, 2025 17:22
@mrgrain mrgrain changed the title chore: increase ulimit per shell and run on ubuntu chore: move ulimit increase to per-step execution in CI workflows Sep 25, 2025
@mrgrain mrgrain enabled auto-merge (squash) September 25, 2025 18:27
@mrgrain mrgrain merged commit f74ad0b into main Sep 26, 2025
102 of 103 checks passed
@mrgrain mrgrain deleted the mrgrain/chore/per-step-ulimit branch September 26, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants