Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seed poc #1626

Draft
wants to merge 37 commits into
base: feature/seed-poc
Choose a base branch
from
Draft

Seed poc #1626

wants to merge 37 commits into from

Conversation

sobolk
Copy link
Member

@sobolk sobolk commented Jun 7, 2024

Problem

Issue number, if available:

Changes

Corresponding docs PR, if applicable:

Validation

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

changeset-bot bot commented Jun 7, 2024

⚠️ No Changeset found

Latest commit: b3ec956

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

): Promise<AuthUser> => {
await this.lock.acquire();
try {
console.log(`creating ${username}, ${password}`);

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information High

This logs sensitive data returned by
an access to password
as clear text.
import { AuthClient, AuthUser, SeedFunction } from './types.js';
import { DefaultAuthClient } from './auth_client.js';
import { CognitoIdentityProviderClient } from '@aws-sdk/client-cognito-identity-provider';
import { SchemaSeedable, Seedable } from '@aws-amplify/plugin-types';

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused import SchemaSeedable.
packages/backend-seed/src/index.ts Fixed Show fixed Hide fixed
import { defineSeed } from '@aws-amplify/backend';
import type { Schema } from './data/resource';
import { defineSeed2, KeysByType, PickByType } from '@aws-amplify/backend-seed';
import { SchemaSeedable, Seedable } from '@aws-amplify/plugin-types';

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note test

Unused import SchemaSeedable.
);
});

let foo: PickByType<typeof backend, Seedable<'auth'>>;

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note test

Unused variable foo.
});

let foo: PickByType<typeof backend, Seedable<'auth'>>;
let bar: PickByType<typeof backend, Seedable<'data'>>;

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note test

Unused variable bar.
let foo: PickByType<typeof backend, Seedable<'auth'>>;
let bar: PickByType<typeof backend, Seedable<'data'>>;

let foo2: KeysByType<typeof backend, Seedable<'auth'>>;

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note test

Unused variable foo2.
let bar: PickByType<typeof backend, Seedable<'data'>>;

let foo2: KeysByType<typeof backend, Seedable<'auth'>>;
let bar2: KeysByType<typeof backend, Seedable<'data'>>;

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note test

Unused variable bar2.
test-projects/seed-poc/amplify/backend.ts Fixed Show fixed Hide fixed
packages/backend-seed/src/index.ts Fixed Show fixed Hide fixed
*
* This means that schema type can be passed through defineData -> backend -> access backend props.
*/
let dataSchema = backend.data.schema;

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note test

Unused variable dataSchema.
}

createUser = async (
username: string,

Check failure

Code scanning / CodeQL

Insecure randomness High

This uses a cryptographically insecure random number generated at
Math.random()
in a security context.
This uses a cryptographically insecure random number generated at
Math.random()
in a security context.

createUser = async (
username: string,
password: string

Check failure

Code scanning / CodeQL

Insecure randomness High

This uses a cryptographically insecure random number generated at
Math.random()
in a security context.
This uses a cryptographically insecure random number generated at
Math.random()
in a security context.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant