Fix incorrect scrolling when Wrap is set to true
#97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fprint into the View doesn't scroll correctly content if `Autoscroll` and `Wrap` are turned on. It's caused when checking buffer lines while using incorrect slice.
mjarkk
reviewed
Jul 16, 2021
This example just test the autorscroll and wrap together. This can be recreated by using `active.go` or `custom_frames.go` example and resize terminal so the text in the second view will be forced to wrap.
mjarkk
approved these changes
Jul 16, 2021
|
could you please make a new release with this fix? |
|
Ofc, here you go v1.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fprint into the View doesn't scroll correctly content if
AutoscrollandWrapare turned on.It's caused by using incorrect slice when checking length of lines if the content should be scrolled and how much.
There is new test for this called
wrap_autorscroll.gowhich adds content to the view when hittingTabkey.