-
Notifications
You must be signed in to change notification settings - Fork 40
Build Testing approach using tcell simulation screen #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Oh i'm just thinking of something wouldn't it be nice if we have tests for the examples? And can you add testing capabilities to the readme features section? |
Yeah sounds good to me, I'll add a set of tests to one of the examples then reference to this from the docs showing how to run tests. Playing around with how/what to expose, tests still look a bit busy so might add a few helper methods to make them nicer to write. |
d512a4a
to
62af4b5
Compare
So I'm pretty happy with the way the tests have worked out (except I have a file called Be great to get some thoughts on this before I write up the docs. The |
62af4b5
to
cbab3b7
Compare
Any thoughts on this one? If we're happy with the approach I can finish off the docs and get this ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya this is looking good!
I've personally not written a lot of test so i'm probably not the one to tell whats right or wrong but from what i can see in the code it looks good and it seems we can expend on this code.
I would like to have this merged as the possibility to easily write tests is always better than no possibility (or is very hard) to test.
Think this should be all set, I've added some basic docs to the README and removed the usage of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, only some documentation i think could be changed
One last thing. Can you update to the latest master, after that I'll merge it :) |
6cb2ae1
to
bf5a02d
Compare
No worries, I've rebased this onto the current |
Related issue
#86
Describe
This is WIP looking at building a simple to use integration testing approach for gocui. The aim is to allow input and assertion about the
resulting screen content.
Todo
[ ] Add some sample tests to the _examplesnot got time to complete this item atm.