Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge jesseduffields master #8

Merged
merged 37 commits into from
Apr 29, 2019
Merged

Merge jesseduffields master #8

merged 37 commits into from
Apr 29, 2019

Conversation

mjarkk
Copy link
Member

@mjarkk mjarkk commented Apr 27, 2019 •
edited by glvr182
Loading

Fixes #8

@mjarkk mjarkk closed this Apr 27, 2019
@mjarkk mjarkk force-pushed the merge-jesseduffields-master branch from 5c10e9d to c7fd251 Compare April 27, 2019 20:08
frizinak and others added 28 commits April 27, 2019 22:11
@frizinak @mjarkk
Visually wide character support
f50da5a
@jesseduffield @mjarkk
default to input mode of InputEsc
8e407b7
@jesseduffield @mjarkk
Ignore char keys when in an editable panel
d1cbd48
@jesseduffield @mjarkk
bold highlighted text
d9a7952
@jesseduffield @mjarkk
support collapsed edges (WIP)
8d3fcc6
@jesseduffield @mjarkk
revert bolding of box character
e572e63
@jesseduffield @mjarkk
disable overlapping views for now
1dc2347
@jesseduffield @mjarkk
defining overlapping edge support in the Gui constructor
c50a372
@jesseduffield @mjarkk
make view dimensions accessible
2fb90d3
@jesseduffield @mjarkk
use dimensions method rather than function
a80ffd8
@jesseduffield @mjarkk
flush the gui before polling for any events
6c1b364
@jesseduffield @mjarkk
enforce that keybindings can only be handled by a single handler, pri…
f27fbaa 
…oritising view handlers over global handlers
@jesseduffield @mjarkk
ignore global rune keybindings on editable views
b2e97d2
@jesseduffield @mjarkk
move cursor directly rather than through function because the old way…
32c5b9b 
… was causing issues
@jesseduffield @mjarkk
support subtitles on panels
4ff4056
@jesseduffield @mjarkk
use jesse's fork of termbox which handles poll event errors
d6ff636
@remyabel2 @mjarkk
view.go: add ViewLinesHeight()
6aacc83
@jesseduffield @mjarkk
missed a couple of imports that I need to switch to my fork of termbox
44898ff
@jesseduffield @mjarkk
use LinesHeight instead of ViewLinesHeight
4869a57
@jesseduffield @mjarkk
convert tab runes to 4 spaces
9673d56
@jesseduffield @mjarkk
don't truncate lines on wrapped views
6c25764
@jesseduffield @mjarkk
use go-errors package to give stack traces to new errors
219f0b0
@jesseduffield @mjarkk
use standard errors when defining package level errors and wrap when …
53e7c0b 
…percolating up
@jesseduffield @mjarkk
add loader animations to views with the HasLoader bool set
605f01c
@jesseduffield @mjarkk
stop polling termbox events after closing the gui
569bfa3
@jesseduffield @mjarkk
fix performance issue causing high cpu drain
106cbe4
@jesseduffield @mjarkk
don't write subtitle outside of view's bounds
b2f96ac
@jesseduffield @mjarkk
support views of height 1 or even negative height
95d85f5
@mjarkk mjarkk reopened this Apr 27, 2019
@mjarkk
Copy link
Member Author

mjarkk commented Apr 27, 2019 •
edited
Loading

This is still a WIP due to a number of bugs:

  • The stdin example doesn't work
  • Examples panic on exit
  • Original unknown view error check doesn't work

@glvr182 glvr182 mentioned this pull request Apr 27, 2019
Closed
@mjarkk
Most examples work but there are still problems
563a1c8 
- The stdin example doesn't work
- Examples panic on exit
- Original unknown view error check doesn't work
@glvr182 glvr182 added the WIP Work In Progress label Apr 27, 2019
@glvr182 glvr182 mentioned this pull request Apr 28, 2019
Closed
golangcibot
golangcibot reviewed Apr 28, 2019
View reviewed changes
gui.go Outdated Show resolved Hide resolved
keybinding.go Outdated Show resolved Hide resolved
@mjarkk
Copy link
Member Author

mjarkk commented Apr 28, 2019

after some looking on the original repo the stdin example is supposed to do that :)
it works just fine when running: ls | go run _examples/stdin.go, issue: jroimartin#125

@mjarkk mjarkk requested review from glvr182 and skanehira April 28, 2019 15:27
@mjarkk mjarkk removed the WIP Work In Progress label Apr 28, 2019
glvr182
glvr182 approved these changes Apr 28, 2019
View reviewed changes
view.go Outdated Show resolved Hide resolved
@mjarkk mjarkk mentioned this pull request Apr 28, 2019
Open
skanehira
skanehira requested changes Apr 29, 2019
View reviewed changes
Copy link

@skanehira skanehira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
I have some comment.

view.go Outdated Show resolved Hide resolved
escape.go Show resolved Hide resolved
gui.go Outdated Show resolved Hide resolved
gui.go Outdated Show resolved Hide resolved
@mjarkk
Moved to loader to component
c62d980 
Also changed the suggestion from skanehira
@mjarkk mjarkk merged commit f4d7a4b into master Apr 29, 2019
@mjarkk mjarkk deleted the merge-jesseduffields-master branch April 29, 2019 06:02
@glvr182 glvr182 mentioned this pull request Apr 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golangcibot golangcibot golangcibot left review comments

@glvr182 glvr182 glvr182 approved these changes

@skanehira skanehira skanehira approved these changes

Assignees

@mjarkk mjarkk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mjarkk @skanehira @glvr182 @golangcibot @frizinak @jesseduffield @remyabel2