-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prettify examples: add main demo screen to select specific examples #117
base: master
Are you sure you want to change the base?
Conversation
* encapsulate each example * add README.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should use go run .
in the examples to keep it simpeler
* use 'go run .' in usage and text message * make 'main' view sensitive to screen dimensions
I'm just wondering, why did you use all the I don't really understand the reason to put these assignements to a function where you don't check the return value, so I'm wondering what was your reason to add them there. |
Humm, sorry to be confusing. |
Ok... so let's wait for @mjarkk input. |
I personally don't like the Tough that said they are also out of the scope of this PR so let's not add them. |
@mjarkk - I fixed the github workflow and therefore need another approval. |
I haven't been around for some time and now I see that this is not really merged. So I will just give here my opinion, but @mjarkk feel free to merge. I can see that most of the As for the PR. At first I was a bit hesitant as I like to have possibility to run just one program using |
This patch allows to compile all examples in one binary.
A main 'demo' example is added on top allowing to run each of the specific examples - although each example can still be run individually. see the added README