-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented mouse release handling #110
Conversation
ccdef6c
to
266011f
Compare
c37c93d
to
a87bdf2
Compare
@mjarkk I was thinking about this feature a bit more today and I am not sure anymore whether this is the best solution. Also, currently a mouse press can only be detected on a view, it would make more sense if a global mouse key binding would also trigger if no view is under the mouse on the down event. |
I'm sorry for the delay, was a bit off during the holidays so didn't have time to check what's going on. This looks good. Not really sure though. Maybe there could be an option where the user could choose where the |
@dankox I agree on having the option. |
The release on origin view as default make sense. But I'm not sure from "backward compatibility". I'm not even sure if anybody was using it before the Anyway, this is kinda tricky question and not sure. @mjarkk what do you think about it? |
Hmm good point, from that standpoint it should by default use the old behaviour |
I don't think we should add such an option. How about this.. The mouse down and up are triggered on the views they happen on but the mouse event data add an extra property like |
Hmm that sounds confusing. |
Good point, lets merge this first. |
This PR adds/fixes a few things: