Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in _examples/ #107

Merged
merged 3 commits into from
Dec 3, 2021
Merged

Conversation

coloursofnoise
Copy link

  • Add KeyBackspace keybind to dynamic.go to match input prompt ("Backspace: Delete View")
  • Fix table alignment in table.go
    • Spacing issue caused by not accounting for empty chars being rendered as ' ' in View.draw:
      spacing issue
    • Minor issue in example when trying to align columns properly:
      alignment issue
    • (fixed):
      fixed table
  • Disable visible cursor in mouse.go due to it being entirely mouse-controlled

view.go Outdated Show resolved Hide resolved
_examples/mouse.go Show resolved Hide resolved
_examples/table.go Outdated Show resolved Hide resolved
_examples/table.go Outdated Show resolved Hide resolved
view.go Outdated Show resolved Hide resolved
@dankox
Copy link

dankox commented Nov 27, 2021

If you could try and incorporate changes from #109 and see if that works for this, that would be good. It should target the table.go case where SetWritePos didn't work as expected.

@coloursofnoise
Copy link
Author

Branch has been rebased onto master to incorporate changes from #109

@coloursofnoise coloursofnoise requested a review from mjarkk December 3, 2021 07:30
Copy link
Member

@mjarkk mjarkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjarkk mjarkk merged commit 5799ff9 into awesome-gocui:master Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants