Upgrade subnet-evm to v0.5.11 #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cam-schultz
requested review from
michaelkaplan13,
minghinmatthewlam,
gwen917,
geoff-vball and
bernard-avalabs
as code owners
peers/external_handler.go
Outdated
| @@ -125,6 +126,7 @@ func (h *RelayerExternalHandler) HandleInbound(_ context.Context, inboundMessage | |||
| h.responseChans[blockchainID] <- inboundMessage | |||
| }(inboundMessage, blockchainID) | |||
| } else { | |||
| h.log.Debug("ignoring message", zap.Stringer("op", inboundMessage.Op())) | |||
There was a problem hiding this comment.
Capitalized all the logs in this package
tests/basic_relay.go
Outdated
| @@ -96,8 +96,9 @@ func BasicRelay(network interfaces.LocalNetwork) { | |||
| ) | |||
|
|
|||
| relayerConfig := config.Config{ | |||
| LogLevel: logging.Info.LowerString(), | |||
| NetworkID: peers.LocalNetworkID, | |||
| LogLevel: logging.Debug.LowerString(), | |||
There was a problem hiding this comment.
do we want to leave as debug?
There was a problem hiding this comment.
Whoops, reverted
There was a problem hiding this comment.
Whoops, reverted
| NetworkID: peers.LocalNetworkID, | ||
| LogLevel: logging.Debug.LowerString(), | ||
| // TODO: There's currently a bug in ANR v1.7.4-rc.0 that specifies the network ID as 0. We should change this back to peers.LocalNetworkID once fixed. | ||
| NetworkID: 0, |
There was a problem hiding this comment.
can you update peer.LocalNetworkID to use github.com/ava-labs/avalanche-network-runner/utils/constants.DefaultNetworkID?
geoff-vball
previously approved these changes
Feb 1, 2024
cam-schultz
requested review from
michaelkaplan13,
minghinmatthewlam and
geoff-vball
geoff-vball
approved these changes
Feb 1, 2024
minghinmatthewlam
approved these changes
Feb 1, 2024
michaelkaplan13
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Upgrades subnet-evm to v0.5.11 and avalanchego to v1.10.18. Unblocks ava-labs/icm-contracts#263
How this works
Self explanatory for the most part. One change to note is that the relayer in the E2E test is now configured with NetworkID=0, rather than NetworkID=1337. This is to workaround a bug in avalanche-network-runner that has since been merged, but not yet included in a release.
How this was tested
CI
How is this documented
N/A