-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACP-77: Update ConvertSubnetTx
#3397
base: implement-acp-77-deactivation
Are you sure you want to change the base?
ACP-77: Update ConvertSubnetTx
#3397
Conversation
// Initial balance for this validator | ||
Balance uint64 `serialize:"true" json:"balance"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR does allow the validator to be initially inactive (by having a 0 balance)
// [Signer] is the BLS key for this validator. | ||
// Note: We do not enforce that the BLS key is unique across all validators. | ||
// This means that validators can share a key if they so choose. | ||
// However, a NodeID + Subnet does uniquely map to a BLS key | ||
Signer signer.Signer `serialize:"true" json:"signer"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than using signer.Signer
- should we just us the bls.ProofOfPossession
struct? If we were to ever change the format of the BLS key... having the interface may be nice... But it feels a bit weird to use an interface where only one value is valid.
…cp-77-update-convert-subnet-tx
…cp-77-update-convert-subnet-tx
…date-convert-subnet-tx
…date-convert-subnet-tx
…date-convert-subnet-tx
…date-convert-subnet-tx
…date-convert-subnet-tx
// removed from the validator set. | ||
RemainingBalanceOwner message.PChainOwner `serialize:"true" json:"remainingBalanceOwner"` | ||
// This owner has the authority to manually deactivate this validator. | ||
DeactivationOwner message.PChainOwner `serialize:"true" json:"deactivationOwner"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To align with the spec:
DeactivationOwner message.PChainOwner `serialize:"true" json:"deactivationOwner"` | |
DisableOwner message.PChainOwner `serialize:"true" json:"disableOwner"` |
…date-convert-subnet-tx
…date-convert-subnet-tx
…date-convert-subnet-tx
Why this should be merged
How this works
How this was tested