[Feature] add blockchain_alias blockchain-spec #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boulix3
changed the title
dasconnor
reviewed
Dec 14, 2022
There was a problem hiding this comment.
I think this looks good but want @felipemadero to take a look
holisticode
reviewed
Dec 14, 2022
|
Awesome, thanks for the feedback. |
|
Oh right, I didn't see this one. Fixing right now. |
felipemadero
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello this Pull Request adds the "blockchain_alias" option in the blockchainSpecs parameter.
It calls the Admin.AliasChain api when the custom blockchain is ready.
With the timestampvm example, using the timestamp alias, you can use 127.0.0.1:9650/ext/bc/timestamp instead of 127.0.0.1:9650/ext/bc/E8isHenre76NMxbJ3munSQatV8GoQ4XKWQg9vD34xMBqEFJGf.