Skip to content

Commit

Permalink
Merge pull request #238 from ava-labs/fix-some-logs
Browse files Browse the repository at this point in the history
fix some error %s that should be %v due to possible nil error
  • Loading branch information
felipemadero authored Aug 16, 2022
2 parents 11b925f + 5119cbc commit b9e6532
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion cmd/server/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ func serverFunc(cmd *cobra.Command, args []string) (err error) {
rootCancel()
// wait for server stop
waitForServerStop := <-errc
log.Warn("closed server; %s", waitForServerStop)
log.Warn("closed server: %v", waitForServerStop)
case serverClosed := <-errc:
// server already stopped here
_ = rootCancel
Expand Down
4 changes: 2 additions & 2 deletions server/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ func (s *server) Run(rootCtx context.Context) (err error) {
s.log.Warn("root context is done")

if !s.cfg.GwDisabled {
s.log.Warn("closed gRPC gateway server: %s", s.gwServer.Close())
s.log.Warn("closed gRPC gateway server: %v", s.gwServer.Close())
<-gwErrc
}

Expand All @@ -198,7 +198,7 @@ func (s *server) Run(rootCtx context.Context) (err error) {
case err = <-gRPCErrc:
s.log.Warn("gRPC server failed: %s", err)
if !s.cfg.GwDisabled {
s.log.Warn("closed gRPC gateway server: %s", s.gwServer.Close())
s.log.Warn("closed gRPC gateway server: %v", s.gwServer.Close())
<-gwErrc
}

Expand Down

0 comments on commit b9e6532

Please sign in to comment.