next round of PR comments

cmd/control/control.go

@@ -68,15 +68,18 @@ func NewCommand() *cobra.Command {
 		newGetSnapshotNamesCommand(),
 	)
 
+	lvl, err := logging.ToLevel(logLevel)
+	if err != nil {
+		panic(err)
+	}
 	lcfg := logging.Config{
-		DisplayLevel: logging.Info,
+		DisplayLevel: lvl,
 		// this will result in no written logs, just stdout
 		// to enable log files, a logDir param should be added and
 		// accordingly possibly a flag
 		LogLevel: logging.Off,
 	}
 	logFactory := logging.NewFactory(lcfg)
-	var err error
 	log, err = logFactory.Make(constants.LogNameControl)
 	if err != nil {
 		panic(err)

cmd/ping/ping.go

@@ -37,11 +37,15 @@ func NewCommand() *cobra.Command {
 }
 
 func pingFunc(cmd *cobra.Command, args []string) error {
+	lvl, err := logging.ToLevel(logLevel)
+	if err != nil {
+		return err
+	}
 	lcfg := logging.Config{
-		DisplayLevel: logging.Info,
+		DisplayLevel: lvl,
+		LogLevel:     logging.Off,
 	}
 	logFactory := logging.NewFactory(lcfg)
-	var err error
 	log, err := logFactory.Make(constants.LogNameControl)
 	if err != nil {
 		return err

tests/e2e/e2e_test.go

@@ -71,7 +71,7 @@ func init() {
 	flag.StringVar(
 		&logDir,
 		"log-dir",
-		logging.Info.String(),
+		"",
 		"log directory",
 	)
 	flag.StringVar(