-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use the chain name as a blockchain alias #535
Conversation
Here is an example with a subnet-evm. $ curl -X POST --data '{
"jsonrpc":"2.0",
"id" :1,
"method" :"eth_baseFee",
"params" :[]
}' -H 'content-type:application/json;' http://127.0.0.1:9650/ext/bc/mysubnet/rpc
{"jsonrpc":"2.0","id":1,"result":"0x5d21dba00"}
$ curl -X POST --data '{
"jsonrpc":"2.0",
"id" :1,
"method" :"eth_baseFee",
"params" :[]
}' -H 'content-type:application/json;' http://127.0.0.1:9650/ext/bc/2VqqvGNY71aVWm1V29HvNiv6TrdHvpg3kvceKVYP2PVrcVUe6A/rpc
{"jsonrpc":"2.0","id":1,"result":"0x5d21dba00"} |
@dasconnor can you please check this out? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you fix the failing tests, we can merge this
It's fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks for the patience!
Sorry, one last ask, can you sign your commit? https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits |
No problem, I just squashed my old commits and signed the new commit. |
All merged! It'll go out in the next release, probably later this week. |
Related to the issue #476
I chose to use the subnet name as the blockchain alias. I figured it was not useful to ask for another parameter since there can only have one chain per subnet with avalanche-cli.