-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(yabloc): add camera and vector map localization #3946
feat(yabloc): add camera and vector map localization #3946
Conversation
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3946 +/- ##
==========================================
- Coverage 14.72% 4.92% -9.81%
==========================================
Files 1464 69 -1395
Lines 103173 2337 -100836
Branches 30513 268 -30245
==========================================
- Hits 15197 115 -15082
+ Misses 71476 2145 -69331
+ Partials 16500 77 -16423
☔ View full report in Codecov by Sentry. |
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (Also confirmed that both YabLoc and NDT mode works with given sample rosbags)
localization/pose_initializer/src/pose_initializer/pose_initializer_core.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Kento Yabuuchi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM about pose_initilizer
Signed-off-by: Kento Yabuuchi <[email protected]>
Description
Add YabLoc (localization with camera and vector map) as a new location estimation method.
The user can choose whether to run NDT or YabLoc by specifying
localization_mode
as an argument when launching autoware.YabLoc is a pose_estimator consisting of multiple nodes, which estimates position and orientation from sensor inputs and publishes
localization/pose_estimator/pose_with_covariance
.Packages related to YabLoc are located under
localization/yabloc/
.The following figure shows where the code has been changed and added. Red frames indicate edited files, and red blocks indicate added files.
All yabloc-related nodes are launched in the following namespace
Related links
Tests performed
I confirmed that logging_simulator works correctly with the following ROSBAG created by AWSIM.
rosbag : This link is TEIR IV internal link now. I will replace it with publicly available rosbag.How to launch with NDT
How to launch with YabLoc
yabloc_ndt_localizer_selection_para.mp4
ndt
andyabloc
are specified for localization_mode, butlidar
andcamera
are valid options in the latest version.Notes for reviewers
This PR needs to be merged with
There is also a PR to autoware-documentation.
Interface changes
Nothing.
Effects on system behavior
By default, it starts as before.
If
localization_mode:=camera
is added as an argument when launching autoware, YabLoc runs instead of NDT.When yabloc is used,
matching_score
, which is NDT's diagnostics, is not published.Note that the absence of
matching_score
does not affect the system error monitor.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.