Rename BundleHeader to SealedBundleHeader#1531
Merged
liuchengxu merged 3 commits intomainfrom Jun 11, 2023
Merged
Conversation
nazar-pc
approved these changes
Jun 11, 2023
1 task
i1i1
added a commit
to autonomys/subspace-pulsar-sdk
that referenced
this pull request
Jun 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applied suggestion from #1496 (comment), pure renamings. I'm not super happy with the nested
sealed_header.headerhonestly, but I don't have a better idea and do agree the maintainability is more important.PreliminaryBundleHeader=>BundleHeaderBundleHeader=>SealedBundleHeaderCode contributor checklist: