Change sync from DSN to use larger number of peers and simple majority#1523
Merged
Change sync from DSN to use larger number of peers and simple majority#1523
Conversation
shamil-gadelshin
previously approved these changes
Jun 8, 2023
Contributor
shamil-gadelshin
left a comment
shamil-gadelshin
left a comment
There was a problem hiding this comment.
It makes sense in general, I added several minor comments.
crates/subspace-service/src/dsn/import_blocks/segment_headers.rs
Outdated
Show resolved
Hide resolved
crates/subspace-service/src/dsn/import_blocks/segment_headers.rs
Outdated
Show resolved
Hide resolved
nazar-pc
force-pushed
the
change-dsn-sync-parameters
branch
from
8ef0974 to
61398a6
Compare
shamil-gadelshin
approved these changes
Jun 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1516
Code contributor checklist: