Abstract out domain_block_preprocessor module#1294
Merged
liuchengxu merged 7 commits intomainfrom Mar 24, 2023
Merged
Conversation
…_primary_block` No logical changes.
vedhavyas
approved these changes
Mar 24, 2023
| Ok(extrinsics) | ||
| } | ||
|
|
||
| pub struct SystemDomainBlockPreprocessor<Block, PBlock, Client, PClient> { |
Contributor
There was a problem hiding this comment.
maybe move it under system_bundle_preprocessor since we the similar structure for processor as well for consistency
Contributor
Author
There was a problem hiding this comment.
It's not the final form, some further refactoring changes are expected in the follow up PR so I kept it as a single file for simplicity.
i1i1
added a commit
to autonomys/subspace-pulsar-sdk
that referenced
this pull request
Mar 26, 2023
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a pure refactoring towards a reusable component
domain_block_preprocessorthat is responsible for converting a primary block to a specific domain block. The next step will be making the runtime api usages in this process flexible to support both the client and stateless runtime alternative so that it can be used by both the executor and fraud proof verifier.Part of #1274
Code contributor checklist: