Conversation
ParthDesai
force-pushed
the
add-runtime-for-eth-domain
branch
3 times, most recently
from
23fbfda to
7faba17
Compare
ParthDesai
force-pushed
the
add-runtime-for-eth-domain
branch
from
7faba17 to
9e78000
Compare
ParthDesai
force-pushed
the
add-runtime-for-eth-domain
branch
from
9e78000 to
72effe8
Compare
ParthDesai
requested review from
liuchengxu,
nazar-pc,
rg3l3dr and
vedhavyas
as code owners
nazar-pc
left a comment
nazar-pc
left a comment
There was a problem hiding this comment.
Looks fine overall.
I'd like to get feedback from @liuchengxu though.
Just some minor nits here.
There was a problem hiding this comment.
I'm not sure they ever will. Execution is deterministic, timestamp must come from the consensus chain block then.
| Messenger: pallet_messenger = 6, | ||
| Transporter: pallet_transporter = 7, |
There was a problem hiding this comment.
@vedhavyas looks like we'll want this indices to be constants, otherwise feels fragile. Maybe even some integration test if we have infra for that.
There was a problem hiding this comment.
I dont like it as well. We were already bitten by it. I have a plan to have a safer approach soon that should remove this dependency.
But then yes, maybe constant should be deterrent until then
vedhavyas
left a comment
vedhavyas
left a comment
There was a problem hiding this comment.
Make sense.
I wish rename from eth-relay to cor-eth-relay was part of the first commit only.
There was a problem hiding this comment.
not sure if we are using this anywhere
There was a problem hiding this comment.
This was copied from core-payments runtime.
Upon investigation, It is indeed not in use both here as well as in core-payments. Maybe it is worth removing from core-payments. I have removed it from here.
liuchengxu
left a comment
liuchengxu
left a comment
There was a problem hiding this comment.
Make sense overall!
Regarding the timestamp, I'm unsure about the entire context, we can discuss how to support it if you can share more background and requirement somewhere.
4 participants
Description
This PR adds runtime for ethereum relay domain.
The runtime is not integrated in the node in this PR. I will be opening separate PR for that.
Closes #1204
Code contributor checklist: