docs(wish): record re-review #2 SHIP and the promotion gate for #2817 - #2839
Conversation
Orchestrator ledger write: re-review #2 evidence block (pinned 0d0641f, SHIP, zero CRITICAL/HIGH, 3984 tests), disposition tense refreshed, #2838 noted, and the human promotion sequence (#2822 + #2833 to main first, then #2817 merge commit; SHIPPED only after merge + on-host dogfood). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018QrkgYMEEhrWTUo5E7Nkjg
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a3e00d0fd4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| 3984 pass. Zero CRITICAL, zero HIGH. Non-blocking: M16 (hook authority read failed open on `{"orchestration":{}}`, | ||
| extra keys, and an unimplemented `GENIE_CONFIG_FILE` — fixed in #2838 to mirror the CLI's strict schema with the | ||
| fixture asserting both readers agree), M17 (plugin README H3 row — #2838), L1 (ledger tense — this entry). |
There was a problem hiding this comment.
At the reviewed 0d0641f97 snapshot, M16 means readLifecycleAuthority can still open the local lifecycle DB for malformed authority configurations that the CLI rejects, and a hook-only GENIE_CONFIG_FILE can redirect the hook away from the config where Orca was selected. Labeling this non-blocking and approving immediate promotion can therefore ship a known fail-open path across the explicit authority decision; require #2838 to merge and receive a fresh exact-head review before marking #2817 promotable.
AGENTS.md reference: AGENTS.md:L38-L38
Useful? React with 👍 / 👎.
| - **Re-review #2 of #2817 (dev→main) — SHIP (2026-08-30):** same reviewer profile, pinned snapshot | ||
| `0d0641f97b800f344349a1e97f47a8ffef0302e3` (dev tip after #2835/#2836/#2837). H7 closed with a negative control — |
There was a problem hiding this comment.
Adding the SHIP verdict leaves the canonical Status field at the top of this wish saying that #2817 was reviewed FIX-FIRST, fixes are in flight, and re-review is pending. Anyone consulting the summary rather than the review ledger receives the opposite disposition from this new entry and the INDEX; retain IN_PROGRESS until promotion if intended, but refresh its detail to record re-review #2 and the remaining promotion/dogfood gate.
Useful? React with 👍 / 👎.
1 participant
Orchestrator ledger write (touches only
.genie/): re-review #2 evidence block (pinned0d0641f97, SHIP, zero CRITICAL/HIGH, 3984 tests), disposition tense refreshed, #2838 noted, and the human promotion sequence — merge #2822 + #2833 tomainfirst (release pipeline runs its controls frommain), then #2817 with a merge commit; wish moves to SHIPPED only after the authorized merge plus the on-host dogfood.bun run wishes:lintOK.🤖 Generated with Claude Code
https://claude.ai/code/session_018QrkgYMEEhrWTUo5E7Nkjg