Repository navigation
fix(hooks): session-start authority read mirrors the cli schema exactly and fails closed - #2838
Conversation
…ly and fails closed Re-review #2 (M16): the hook's self-contained authority read diverged from src/lib/orchestration-mode.ts in the fail-OPEN direction — it accepted {"orchestration":{}} and extra keys under orchestration as standalone (the CLI throws invalid_orchestration_authority on both) and honored a GENIE_CONFIG_FILE override the CLI never implemented, so a doc-following operator could get the CLI refusing local lifecycle while the hook opened genie.db on every session start. Mirror the strict schema exactly: same path ($GENIE_HOME/config.json), mode required, no other keys, anything else fails closed. The barrier fixture now asserts every rejected shape and both accepted shapes; session-context.cjs regenerated. M17: the shipped plugin README's H3 row now lists the two new degradation causes (Orca authority; unreadable/invalid orchestration config). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018QrkgYMEEhrWTUo5E7Nkjg
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…#2839) Orchestrator ledger write: re-review #2 evidence block (pinned 0d0641f, SHIP, zero CRITICAL/HIGH, 3984 tests), disposition tense refreshed, #2838 noted, and the human promotion sequence (#2822 + #2833 to main first, then #2817 merge commit; SHIPPED only after merge + on-host dogfood). Claude-Session: https://claude.ai/code/session_018QrkgYMEEhrWTUo5E7Nkjg Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
1 participant
Re-review #2 of #2817 returned SHIP with two non-blocking MEDIUMs; this closes both.
M16 — the hook's authority read diverged from
src/lib/orchestration-mode.tsin the fail-open direction:{"orchestration":{}}and extra keys underorchestrationresolved to standalone (the CLI throwsinvalid_orchestration_authority), and it honoured aGENIE_CONFIG_FILEoverride the CLI never implemented — an operator following that CLAUDE.md line could have the CLI refusing local lifecycle while the hook openedgenie.dbon every session start. Now mirrors the strict schema exactly (same path$GENIE_HOME/config.json,moderequired, no other keys, anything else fails closed).authority-barriers.test.tsasserts six rejected shapes and both accepted ones against the shipped bundle;session-context.cjsregenerated.M17 —
plugins/genie/README.mdH3 row lists the two new degradation causes.Validation:
bun test src/lib/v5/authority-barriers.test.ts scripts/hook-bundle-parity.test.ts scripts/release-docs.test.ts→ 57 pass; hook-content / hook-budgets / plugin-skills gates OK; typecheck clean.🤖 Generated with Claude Code
https://claude.ai/code/session_018QrkgYMEEhrWTUo5E7Nkjg