-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added timeout with default value of 30s #132
Conversation
Hey @Cooke thanks for the contribution. We are currently migrating off of request because of the libraries deprecation. We will be moving to axios and exposing the axios config options which will allow you to set the timeout. #134 We can move forward with this PR, but its use would break in PR #134. Let me know if you are able to wait. Thanks |
@davidpatrick we can wait. We are already using our own fork in the meanwhile. Thank you |
Hi @davidpatrick, Just wondering if there was a timeframe for moving to axios? This will solve some issues we're facing but the timing will give us a better idea of how we should proceed right now. |
@apumb working on getting #135 merged asap @Cooke do you want to update this PR to include the new We will need to pass the timeout option through to this new wrapper |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^
@davidpatrick that should hopefully do it. But you should better check it. Also I think I screwed up the ticket references, sorry. |
Thanks @davidpatrick, this is awesome!! |
@Cooke I've merged in the request dep changes, can you rebase this with master? That should resolve the conflicts |
Description
The purpose of this pull request is to add a timeout (with default value) which applies to the request for fetching keys.
The introduction of the timeout setting isn't itself breaking but the default value of 30s could be considered breaking, though it should be a sane value that everyone could live with.
References
Issue #131
Testing
No tests have been added.
This change depends on the timeout functionality of the request lib.
Manual verification has been done and auto tests have been executed with npm test.
Checklist
master