Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing request timeout #131

Closed
Cooke opened this issue Feb 19, 2020 · 0 comments
Closed

Missing request timeout #131

Cooke opened this issue Feb 19, 2020 · 0 comments

Comments

@Cooke
Copy link
Contributor

Cooke commented Feb 19, 2020

Description

Currently the request for fetching keys may never timeout since no timeout is provided to the underlying http request library. In our "shaky" environment we have observed our application "freeze" due to this, forever waiting for new keys. I would expect the library to timeout.

I will associate a pull request with this issue.

Reproduction

It can be reproduced by never accepting or responding to the JWKS request on the remote endpoint.

Environment

Docker alpine nodejs 10 and 12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants