Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IE11 support [SDK-2629] #432

Merged
merged 2 commits into from
Jun 29, 2021
Merged

Add IE11 support [SDK-2629] #432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35d40c3
Transpile to ES5 to support IE11
Widcket Jun 29, 2021
642742a
Exclude constructor line from coverage
Widcket Jun 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/utils/errors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export class AccessTokenError extends Error {
public code: string;

constructor(code: string, message: string) {
super(message);
super(message) /* istanbul ignore next */;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With ES5, code coverage gets reported incorrectly when using the super call inside a constructor. See microsoft/TypeScript#13455

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also see gotwarlost/istanbul#690


// Saving class name in the property of our custom error as a shortcut.
this.name = this.constructor.name;
Expand Down Expand Up @@ -49,7 +49,7 @@ export class HandlerError extends Error {
public code: string | undefined;

constructor(error: Error | AccessTokenError | HttpError) {
super(htmlSafe(error.message));
super(htmlSafe(error.message)) /* istanbul ignore next */;

this.name = error.name;

Expand Down
4 changes: 3 additions & 1 deletion tsconfig.build.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
"noUnusedParameters": true,
"sourceMap": true,
"strict": true,
"target": "es6",
"target": "es5",
"lib": ["es6", "dom"],
"downlevelIteration": true,
"resolveJsonModule": true,
"jsx": "react",
"outDir": "./dist",
Expand Down