Add IE11 support [SDK-2629] #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widcket
added
review:small
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/auth0/nextjs-auth0/5bwq93sKxZ5seidamPCwgrAG2QDi |
Widcket
commented
Jun 29, 2021
| @@ -9,7 +9,7 @@ export class AccessTokenError extends Error { | |||
| public code: string; | |||
|
|
|||
| constructor(code: string, message: string) { | |||
| super(message); | |||
| super(message) /* istanbul ignore next */; | |||
There was a problem hiding this comment.
With ES5, code coverage gets reported incorrectly when using the super call inside a constructor. See microsoft/TypeScript#13455
There was a problem hiding this comment.
Also see gotwarlost/istanbul#690
adamjmcgrath
approved these changes
Jun 29, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR configures TS to transpile to ES5 instead of ES6 to support IE11.
The change adds about 8kb to the zipped build (relevant for serverless).
References
Fixes #415
Testing
This change was tested manually on Browserstack, using the kitchen sink sample app on IE11.
Checklist
main