Skip to content

fix: CheckJWT clones the request #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2021
Merged

fix: CheckJWT clones the request #89

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e76a58
fix: clone request with ctx
jfatta May 21, 2021
cceddfb
fix unnecessary pointer
jfatta May 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion jwtmiddleware.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ func (m *JWTMiddleware) CheckJWT(next http.Handler) http.Handler {

// no err means we have a valid token, so set it into the
// context and continue onto next
*r = *r.Clone(context.WithValue(r.Context(), ContextKey{}, validToken))
r = r.Clone(context.WithValue(r.Context(), ContextKey{}, validToken))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, good catch on this

next.ServeHTTP(w, r)
})
}