chore(state): refactor state into module #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuajbouw
added
C-housekeeping
aleksuss
approved these changes
Jan 26, 2023
aleksuss
reviewed
Jan 26, 2023
joshuajbouw
force-pushed
the
chore/move-state
branch
2 times, most recently
from
18deabe
to
3fec3ec
Compare
joshuajbouw
force-pushed
the
chore/move-state
branch
from
387c8b9
to
5a3da32
Compare
aleksuss
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simply refactors the state into its own module. My motivation is to improve the code quality gradually when required.
How should this be reviewed
Ensure that the refactor is complete, and nothing that has been missed was missed. That would require looking into the
engine/src/engine.rsand ensuring all relevant tests and anything to do with the state has been moved.Additional information
Descoped from a scope creeping PR #662